Ticket #107 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Favicons with errors

Reported by: trac-user Assigned to: fox
Priority: trivial Milestone: 1.2.3
Component: backend Version: HEAD
Keywords: Cc:

Description

With CURL activated, I'm having several problems:

- Some feeds with no favicon (or a gif/png shorcut icon) have a 0 bytes ico file (example: http://cafeina.ladybenko.net/)

- Some feeds with favicon but not in the root directory gets a ico file, but the ico file contents the HTML code instead the proper ico (example: http://www.tabernadelturco.com/)

Maybe a better favicon discover function resolves the problem? I like the fucntion of this wordpress plugin: http://dev.wp-plugins.org/file/favatars/trunk/favatars.php

Sorry for being so boring ;-)

Change History

08/28/06 10:39:42 changed by fox

  • status changed from new to assigned.

The favicon fetching code is really dumb right now, I figured that simply fetching favicon.ico works in most cases. Accepted.

08/28/06 12:00:11 changed by www-ttrss

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [1305]) [project @ merge better favicon handling from wordpress plugin (closes #107)]