Ticket #119 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Handling feeds with broken timestamps

Reported by: trac-user Assigned to: fox
Priority: minor Milestone: 1.2.8
Component: backend Version:
Keywords: Cc:

Description

Sometimes magpie's parse_w3cdtf fails to parse the timestamp for an entry and returns -1.

This check in functions.php (line 469): 

if ($entry_timestamp == "") {

should be something like: 

if ($entry_timestamp == "" || $entry_timestamp == -1) {

so ttrss can set the current time as the timestamp instead.

Examples of broken feeds with bad timestamps:

http://www.pitchforkmedia.com/atom/today

http://www.pitchforkmedia.com/atom/downloads

Change History

02/09/07 15:11:13 changed by trac-user

Also note that strtotime() (rss2) may also return false on error (or -1, in older php versions).

02/09/07 15:18:44 changed by fox

  • status changed from new to assigned.
  • milestone set to 1.2.8.

Nice catch, accepted.

02/09/07 16:00:12 changed by www-ttrss

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [1562]) [project @ better handling of feeds with broken timestamps (closes #119)]