Ticket #191 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

n/p doesn't work in combined mode

Reported by: trac-user Assigned to: fox
Priority: major Milestone: 1.2.20
Component: interface Version:
Keywords: Cc: luis@tieguy.org

Description

I'm trying to use the keyboard shortcuts described in KeyboardShortcuts, but as far as I can tell n/p don't work (at least in combined mode, have not tried other mode.)

Change History

02/19/08 18:54:45 changed by trac-user

  • cc set to luis@tieguy.org.

Gah, why does trac suck so much wrt accounts. cc'ing myself now, sorry for the spam.

02/19/08 19:00:28 changed by fox

Nope, those don't work in combined mode, because there are no separate articles to move - everything is displayed together.

I guess, they could scroll the buffer to the next/prev unread article.

02/19/08 19:04:57 changed by trac-user

<i>I guess, they could scroll the buffer to the next/prev unread article. </i>

That's what google reader does; that behavior works quite well for me.

02/19/08 19:09:32 changed by fox

  • status changed from new to assigned.

OK, accepted.

02/19/08 19:26:06 changed by trac-user

  • summary changed from n/p keyboard nav in combined mode broken? to n/p doesn't work in combined mode.

One other thing: greader marks as read when you hit 'n' and it goes to an unread article; this may work better than the current timer behavior?

BTW, tt-rss is pretty slick stuff- thanks for continuing to work on it when so many people are just going to proprietary services instead.

02/19/08 19:32:55 changed by fox

One other thing: greader marks as read when you hit 'n' and it goes to an unread article; this may work better than the current timer behavior?

The only problem is that in CDM there is no separate active (e.g. loaded) article to mark, what should tt-rss mark? Everything visible in the viewport? Something else?

BTW, tt-rss is pretty slick stuff- thanks for continuing to work on it when so many people are just going to proprietary services instead.

I usually hack on it when I'm bored at work. Being a *nix sysadmin, I'm bored quite often. :)

02/19/08 19:42:40 changed by trac-user

| The only problem is that in CDM there is no separate active (e.g. loaded) article to mark, what | should tt-rss mark? Everything visible in the viewport? Something else?

Well, if you're figuring out what the next unread article is and then scrolling to it in the viewport, can you treat that next unread article as the 'loaded' article for the purpose of marking as read? In other words, what I think you proposed is this:

(1) user hits 'n' (2) software figures out what next unread article is (3) software scrolls viewport to start of that unread article

I'm suggesting adding

(4) mark that unread article (and only that one) read when the scrolling happens.

I don't know anything about the guts of tt-rss/CDM but I guess I'm assuming that once you've done (2) then (4) is easy :)

02/19/08 19:52:47 changed by fox

Hmm.. you mean, mark as read the article which viewport being scrolled to?

02/19/08 19:53:52 changed by trac-user

Yes.

02/19/08 21:00:20 changed by www-ttrss

(In [2285]) [project @ assorted fixes, support for n/p shortcuts in CDM (refs #191)]

02/19/08 21:30:32 changed by www-ttrss

(In [2287]) [project @ CDM highlight/display tweaks; tweaks for n/p hotkeys (refs #191)]

02/19/08 23:37:33 changed by fox

  • milestone set to 1.2.20.

02/20/08 12:01:18 changed by fox

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in trunk.