mail plugin sender address

Post plugins and custom CSS snippets here
bjorn
Bear Rating Trainee
Bear Rating Trainee
Posts: 4
Joined: 15 Jun 2016, 06:36

mail plugin sender address

Postby bjorn » 15 Jun 2016, 06:44

I did not like how the mail plugin would take the sender address (From header) from config.php. So I changed it to use the users name and email address.

It was a very simple change in the init.php:

185c185
< $mail->AddReplyTo(strip_tags($_REQUEST['from_email']),
---
> $mail->setFrom(strip_tags($_REQUEST['from_email']),

Can this change be put into the official source? How do I submit it to the maintainers?

User avatar
fox
^ me reading your posts ^
Posts: 6267
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: mail plugin sender address

Postby fox » 15 Jun 2016, 10:00

tripping email spoofing protection everywhere sounds like a great idea, op

User avatar
sleeper_service
Bear Rating Overlord
Bear Rating Overlord
Posts: 881
Joined: 30 Mar 2013, 23:50
Location: Dallas, Texas

Re: mail plugin sender address

Postby sleeper_service » 15 Jun 2016, 10:47

bjorn, since you seem a bit slow... I'll translate what fox said:

NO

bjorn
Bear Rating Trainee
Bear Rating Trainee
Posts: 4
Joined: 15 Jun 2016, 06:36

Re: mail plugin sender address

Postby bjorn » 15 Jun 2016, 13:13

Ok, fair call fox about the email spoofing, altho does email spoofing protection trigger only the envelope or the headers too? I am thinking for example SPF only uses the envelope?

Even if the "From:" header could have the users name rather than "Tiny Tiny RSS" would look better to the recipient... but that is just personal opinion. e.g. From: Joe User <noreply@some-ttrss-box.com>

To resolve this for me personally I will copy the mail plugin to a new plugin name/folder so my changes don't get wiped by a future git update.

Thanks.

User avatar
fox
^ me reading your posts ^
Posts: 6267
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: mail plugin sender address

Postby fox » 15 Jun 2016, 13:49

i dunno about from name, it is still more or less spoofing and might trip overzealous filters of something like outlook.com

having a separate plugin copy is a good idea


Return to “Themes and plugins”

Who is online

Users browsing this forum: No registered users and 3 guests