Make GoComics work again plugin

Post plugins and custom CSS snippets here
JustAMacUser
Bear Rating Overlord
Bear Rating Overlord
Posts: 371
Joined: 20 Aug 2013, 23:13

Make GoComics work again plugin

Postby JustAMacUser » 14 Jan 2017, 11:25

As requested, attached is a plugin I quickly threw together to allow TT-RSS to generate an Atom feed internally for the new (Jan. 9/17) GoComics site. (Apparently supporting RSS is too much of a burden for them.)

This plugin is based on the previous feed URLs I used at feedburner and it works for the comics I subscribe to. You should be able to modify it to suit your needs, or just reply for help.
Last edited by JustAMacUser on 14 Jan 2017, 22:07, edited 1 time in total.

JustAMacUser
Bear Rating Overlord
Bear Rating Overlord
Posts: 371
Joined: 20 Aug 2013, 23:13

Re: Make GoComics work again plugin

Postby JustAMacUser » 14 Jan 2017, 22:07

Updated to fix a stupid mistake that caused the plugin handle every feed. Sorry for the trouble.
Attachments
ff_gocomics-1_1.zip
(1.43 KiB) Downloaded 66 times

ibreakcellphones
Bear Rating Trainee
Bear Rating Trainee
Posts: 31
Joined: 28 Mar 2013, 09:49

Re: Make GoComics work again plugin

Postby ibreakcellphones » 15 Jan 2017, 00:28

Works great! One side note. Some of my GoComics feeds were using http://feedproxy.google.com/uclick/<mumble> instead of http://feeds.feedburner.com/uclick/<mumble>, so I had to edit them via the UI, and then the magic happened.

Thanks!

disconn3ct
Bear Rating Trainee
Bear Rating Trainee
Posts: 37
Joined: 12 Apr 2013, 15:07

Re: Make GoComics work again plugin

Postby disconn3ct » 17 Jan 2017, 20:09

I'm getting a 1-day delay on comics. The date is right but the image is from the day before.
It was scraped yesterday at 22:58 local (03:58 UTC). Any other info that could help debug?

Image

JustAMacUser
Bear Rating Overlord
Bear Rating Overlord
Posts: 371
Joined: 20 Aug 2013, 23:13

Re: Make GoComics work again plugin

Postby JustAMacUser » 17 Jan 2017, 21:07

Yeah, it's a known issue because GoComics redirects 404s for specific (i.e. future) comic pages back to the default (e.g. /garfield/2017/01/18 becomes /garfield).

This plugin is actually a subset of a much larger plugin I use to filter a bunch of stuff. In that plugin I have a custom curl wrapper that disables redirects for this. I might need to bring that function into the plugin, but I don't know if I'll get to it today. Maybe tomorrow? I'll post back when it's done.

User avatar
fox
^ me reading your posts ^
Posts: 6267
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Make GoComics work again plugin

Postby fox » 17 Jan 2017, 21:56

if you can rework it into a af_comics filter i can merge it into trunk

JustAMacUser
Bear Rating Overlord
Bear Rating Overlord
Posts: 371
Joined: 20 Aug 2013, 23:13

Re: Make GoComics work again plugin

Postby JustAMacUser » 17 Jan 2017, 22:33

The whole plugin?

User avatar
fox
^ me reading your posts ^
Posts: 6267
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Make GoComics work again plugin

Postby fox » 17 Jan 2017, 22:36

well i think af_comics already has a currently non-functioning embedder for gocomics (i think) so we might as well replace it with something that works

that is if it's possible

JustAMacUser
Bear Rating Overlord
Bear Rating Overlord
Posts: 371
Joined: 20 Aug 2013, 23:13

Re: Make GoComics work again plugin

Postby JustAMacUser » 17 Jan 2017, 22:41

No problem. I'll integrate the code to make it all work and submit a merge request.

JustAMacUser
Bear Rating Overlord
Bear Rating Overlord
Posts: 371
Joined: 20 Aug 2013, 23:13

Re: Make GoComics work again plugin

Postby JustAMacUser » 22 Jan 2017, 11:10

This has been integrated into the af_comics plugin as of fa287f6b. Please use that instead.

(disconn3ct, the af_comics update should fix the issue you described.)

User avatar
fox
^ me reading your posts ^
Posts: 6267
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Make GoComics work again plugin

Postby fox » 22 Jan 2017, 11:38

since the feeds are no longer available i think it would be cool to mention the subscription URL somewhere so that new people would know what to use

i dunno if it's worth placing someplace in the UI tho, maybe here

JustAMacUser
Bear Rating Overlord
Bear Rating Overlord
Posts: 371
Joined: 20 Aug 2013, 23:13

Re: Make GoComics work again plugin

Postby JustAMacUser » 22 Jan 2017, 17:31

UI would work since the plugin already adds a preference page listing supported comics. I'll add this to my to do list for later today.

moosbaue
Bear Rating Trainee
Bear Rating Trainee
Posts: 2
Joined: 24 Jan 2017, 14:38

Re: Make GoComics work again plugin

Postby moosbaue » 24 Jan 2017, 14:45

Thank you for making this happen JustAMacUser
One request (I am not a PHP guy so I maybe wrong here):
https://feeds.feedburner.com/uclick/calvinandhobbes works as intented while https://feeds.feedburner.com/uclick/pho ... er-unicorn does not
Could it be that the "-" signs are missing in regexp in init.php line 82
if (preg_match('#^https?://feeds.feedburner.com/uclick/([a-z]+)#', $fetch_url, $comic)) {....
As said I be wrong here though

Josef

JustAMacUser
Bear Rating Overlord
Bear Rating Overlord
Posts: 371
Joined: 20 Aug 2013, 23:13

Re: Make GoComics work again plugin

Postby JustAMacUser » 24 Jan 2017, 17:38

Yup, you're right. I'll submit a patch to fix that.

moosbaue
Bear Rating Trainee
Bear Rating Trainee
Posts: 2
Joined: 24 Jan 2017, 14:38

Re: Make GoComics work again plugin

Postby moosbaue » 24 Jan 2017, 17:56

Thanks
Josef


Return to “Themes and plugins”

Who is online

Users browsing this forum: No registered users and 2 guests