Search found 7 matches

by trammel
24 Jan 2017, 01:20
Forum: Development
Topic: [PATCH] Third-party library upgrades
Replies: 16
Views: 2278

Re: [PATCH] Third-party library upgrades

enabling people to make pull requests, even stupid ones , incredibly easy.) and, how can you possibly think this is a good thing? Because friction is a real thing and you have to weigh up the cost/benefit trade-off between rejecting stupid ideas and the opportunity cost of not receiving patches and...
by trammel
24 Jan 2017, 01:13
Forum: Development
Topic: [PATCH] Third-party library upgrades
Replies: 16
Views: 2278

Re: [PATCH] Third-party library upgrades

Thanks for fixing this. My suggested patch missed a bunch of other places in the code with the same problem.
by trammel
23 Jan 2017, 12:33
Forum: Development
Topic: [PATCH] Third-party library upgrades
Replies: 16
Views: 2278

Re: [PATCH] Third-party library upgrades

thanks, but please consider using gitlab in the future Sure, but do you mean to create an issue, or a merge request? Because I can't fork the project on gitlab currently, as I would on github. The gitlab docs suggest creating a fork and push those changes to a branch off my fork, or a branch of the...
by trammel
23 Jan 2017, 11:49
Forum: Development
Topic: [PATCH] Third-party library upgrades
Replies: 16
Views: 2278

Re: [PATCH] Third-party library upgrades

by the way, pubsubhubbub looks pretty dead to me, after doing some cursory googling. personally i have literally zero feeds using it. do we really need this code at this point? anyone? There's two in my feed I think. Foreign Policy, http://foreignpolicy.com/category/passport/feed/ Chublic Opinion, ...
by trammel
23 Jan 2017, 11:41
Forum: Development
Topic: [PATCH] Third-party library upgrades
Replies: 16
Views: 2278

Re: [PATCH] Third-party library upgrades

thanks, but please consider using gitlab in the future Sure, but do you mean to create an issue, or a merge request? Because I can't fork the project on gitlab currently, as I would on github. The gitlab docs suggest creating a fork and push those changes to a branch off my fork, or a branch of the...
by trammel
23 Jan 2017, 07:43
Forum: Development
Topic: [PATCH] Third-party library upgrades
Replies: 16
Views: 2278

Re: [PATCH] Third-party library upgrades

I think this commit broke something: 003fdd8a lib: Upgrade php-publisher from ??? to a5d6a0e (2016-11-15) I'm getting exceptions saying that the Subscriber class can't be found. Between the two versions of subscriber.php => Subscriber.php, the class is now namespaced. Explicitly referencing the clas...
by trammel
30 Jan 2015, 08:49
Forum: Development
Topic: Periodic releases are over
Replies: 95
Views: 84903

Re: Periodic releases are over

I'm not really seeing any point in continuing to make arbitrary trunk snapshots aka "releases" once every few months, so I suggest everyone switch to Git already. This way you don't stay with broken af_comics or whatever other plugin for literal months if some stupid site suddenly changes...

Go to advanced search