Public RSS Feed

Development-related discussion, including bundled plugins
psjbeisler
Bear Rating Trainee
Bear Rating Trainee
Posts: 6
Joined: 18 Oct 2013, 03:35

Public RSS Feed

Postby psjbeisler » 18 Oct 2013, 03:41

I noticed my published articles were being rendered funny, specifically with images, after a few tweaks, I'd kinda like to submit a change;

atom-to-html.xsl

Ugly layout:

Code: Select all

                <xsl:for-each select="atom:entry">
                        <h2><a target="_new" href="{atom:link/@href}"><xsl:value-of select="atom:title"/></a></h2>

                         <div name="decodeme" class="content">

                               <xsl:value-of select="atom:content" disable-output-escaping="yes"/>
                        </div>

                        <xsl:if test="enclosure">
                                <p><a href="{enclosure/@url}">Extra...</a></p>
                        </xsl:if>


Pretty layout:

Code: Select all

                <xsl:for-each select="atom:entry">
                        <div style="float: left" name="decodeme" class="content">

                        <h2><a target="_new" href="{atom:link/@href}"><xsl:value-of select="atom:title"/></a></h2>

                                <xsl:value-of select="atom:content" disable-output-escaping="yes"/>
                        </div>

                        <xsl:if test="enclosure">
                                <p><a href="{enclosure/@url}">Extra...</a></p>
                        </xsl:if>
Last edited by psjbeisler on 18 Oct 2013, 06:10, edited 1 time in total.

psjbeisler
Bear Rating Trainee
Bear Rating Trainee
Posts: 6
Joined: 18 Oct 2013, 03:35

Re: Public RSS Feed

Postby psjbeisler » 18 Oct 2013, 04:13

I submitted a commit actually. First time having to actually do it. Cant delete the post though. Feedback is still welcome.
https://github.com/psjbeisler/Tiny-Tiny ... 709e48b73b

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Public RSS Feed

Postby fox » 18 Oct 2013, 09:11

>I submitted a commit actually.

Five times, I think.

Maybe you should post screenshots, because the feeds render fine for me. One before and one after screenshot is enough, though, five is not necessary.

psjbeisler
Bear Rating Trainee
Bear Rating Trainee
Posts: 6
Joined: 18 Oct 2013, 03:35

Re: Public RSS Feed

Postby psjbeisler » 18 Oct 2013, 14:57

fox wrote:>I submitted a commit actually.

Five times, I think.

Maybe you should post screenshots, because the feeds render fine for me. One before and one after screenshot is enough, though, five is not necessary.


I did mention it was my first time using Github right? :D

Before:
Image

After:
Image

The "float:left" in div might not be the best way to call that but, it works

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Public RSS Feed

Postby fox » 19 Oct 2013, 23:38

Image

I dunno. Seems to work fine here.

psjbeisler
Bear Rating Trainee
Bear Rating Trainee
Posts: 6
Joined: 18 Oct 2013, 03:35

Re: Public RSS Feed

Postby psjbeisler » 21 Oct 2013, 06:11

try with more photos maybe? cant just be me, either way wouldnt it be better to keep headers with the content and keep it clean?

levito
Bear Rating Disaster
Bear Rating Disaster
Posts: 77
Joined: 17 Mar 2013, 04:18

Re: Public RSS Feed

Postby levito » 21 Oct 2013, 06:46

Since we don't know if there are floated elements inside articles (like the images in your example), we have to clearfix the div.content.

The easiest and most reliable would be an overflow: hidden here. I'll make a pull request.


Return to “Development”

Who is online

Users browsing this forum: No registered users and 2 guests