Feeds with updates disabled still updating

Development-related discussion, including bundled plugins
ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Feeds with updates disabled still updating

Postby ajs124 » 31 Mar 2016, 00:36

Hey,

so I am subscribed to a few feeds with their update interval set to disabled, but there are still always new articles from them in my reader.

I am not familiar with the Tiny Tiny RSS codebase or database schema, but poked around a bit and it seems as if, at least for two feeds I have this problem with, there are other users on Tiny Tiny RSS instance which are subscribed to the same feed and have the update interval set to default.

Code: Select all

MariaDB [ttrss]> select id,owner_uid,title,feed_url,update_interval,purge_interval,last_updated,site_url,update_method,order_id from ttrss_feeds where title like "netzpol%" or title like "hack a%";
+------+-----------+-----------------+-------------------------------------------+-----------------+----------------+---------------------+-------------------------+---------------+----------+
| id   | owner_uid | title           | feed_url                                  | update_interval | purge_interval | last_updated        | site_url                | update_method | order_id |
+------+-----------+-----------------+-------------------------------------------+-----------------+----------------+---------------------+-------------------------+---------------+----------+
|  107 |         2 | Hack a Day      | http://feeds.feedburner.com/hackaday/LgoM |              -1 |              0 | 2016-03-30 21:28:46 | http://hackaday.com     |             0 |        3 |
|  283 |         5 | Hack a Day      | http://feeds.feedburner.com/hackaday/LgoM |               0 |              0 | 2016-03-30 21:28:47 | http://hackaday.com     |             0 |        0 |
|  602 |         2 | netzpolitik.org | https://netzpolitik.org/feed/             |              -1 |              0 | 2016-03-30 21:25:27 | https://netzpolitik.org |             0 |        5 |
| 1040 |         6 | netzpolitik.org | https://netzpolitik.org/feed/             |               0 |              0 | 2016-03-30 21:25:29 | https://netzpolitik.org |             0 |        0 |
+------+-----------+-----------------+-------------------------------------------+-----------------+----------------+---------------------+-------------------------+---------------+----------+


I am aware that I could just delete the feeds, but I am not overly satisfied with that workaround.

Thanks for your continued developement of Tiny Tiny RSS and sorry if this is just me being dumb somehow.

ajs124

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 31 Mar 2016, 07:52

its possible that the enabled feed is selected for update and then it runs all feeds w/ the same url not checking their update_interval

i'll take a look

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 31 Mar 2016, 20:02

i suggest you collect update daemon logs which mention the disabled feed being updated, not sure what to tell you tbh

ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Re: Feeds with updates disabled still updating

Postby ajs124 » 31 Mar 2016, 21:49

I have no idea what those numbers mean, but here are some logs from a over month ago and from a few hours ago.
Updates might have already disabled a month ago, but I'm not sure about that… the only real difference I see are the two "=> DATE TIME, numbers" that appear sometimes.

Code: Select all

[…]
Feb 18 17:22:46 archlinux php[5881]: [16:22:46/15186] Base feed: https://netzpolitik.org/feed/
Feb 18 17:22:46 archlinux php[5881]: [16:22:46/15186]  => 2016-02-18 15:52:31, 602 2
Feb 18 17:22:47 archlinux php[5881]: [16:22:47/13858]     1.5157 (sec)
Feb 18 22:55:31 archlinux php[5881]: [21:55:31/11740] Base feed: https://netzpolitik.org/feed/
[…]
Feb 18 22:55:31 archlinux php[5881]: [21:55:31/11740]  => 2016-02-18 21:25:22, 602 2
Feb 18 22:55:31 archlinux php[5881]: [21:55:31/11743]     4.3403 (sec)
[…]
Feb 19 00:04:04 archlinux php[5881]: [23:04:04/25481] Base feed: http://feeds.feedburner.com/hackaday/LgoM
Feb 19 00:04:04 archlinux php[5881]: [23:04:04/25481]  => 2016-02-18 22:33:49, 107 2
Feb 19 00:04:05 archlinux php[5881]: [23:04:05/25481]     1.1544 (sec)
[…]
Feb 19 01:06:24 archlinux php[5881]: [00:06:24/2622] Base feed: http://feeds.feedburner.com/hackaday/LgoM
Feb 19 01:06:24 archlinux php[5881]: [00:06:24/2622]  => 2016-02-18 23:34:37, 107 2
Feb 19 01:06:25 archlinux php[5881]: [00:06:25/2627]     1.7454 (sec)


Code: Select all

Mar 31 19:24:21 archlinux php[10631]: [17:24:21/14918] Base feed: http://feeds.feedburner.com/hackaday/LgoM
Mar 31 19:24:21 archlinux php[10631]: [17:24:21/14918]  => 2016-03-31 16:51:54, 107 2
Mar 31 19:24:22 archlinux php[10631]: [17:24:22/13585]     0.9836 (sec)
Mar 31 19:24:22 archlinux php[10631]: [17:24:22/13585]  => 2016-03-31 17:05:46, 1071 6
Mar 31 19:24:23 archlinux php[10631]: [17:24:23/14919]     2.3761 (sec)
[…]
Mar 31 19:24:45 archlinux php[10631]: [17:24:45/14918] Base feed: https://netzpolitik.org/feed/
Mar 31 19:24:45 archlinux php[10631]: [17:24:45/14918]  => 2016-03-31 16:52:07, 602 2
Mar 31 19:24:47 archlinux php[10631]: [17:24:47/13585]     3.2104 (sec)
[…]
Mar 31 19:56:44 archlinux php[10631]: [17:56:44/3808] Base feed: http://feeds.feedburner.com/hackaday/LgoM
Mar 31 19:56:44 archlinux php[10631]: [17:56:44/3808]  => 2016-03-31 17:24:23, 107 2
Mar 31 19:56:44 archlinux php[10631]: [17:56:44/2490]     7.1034 (sec)
Mar 31 19:56:44 archlinux php[10631]: [17:56:44/2490]  => 2016-03-31 17:38:05, 792 5
Mar 31 19:56:45 archlinux php[10631]: [17:56:45/3808]     1.2402 (sec)
[…]
Mar 31 19:57:06 archlinux php[10631]: [17:57:06/3808] Base feed: https://netzpolitik.org/feed/
Mar 31 19:57:06 archlinux php[10631]: [17:57:06/3808]  => 2016-03-31 17:24:47, 602 2
Mar 31 19:57:07 archlinux php[10631]: [17:57:07/3811]     1.4151 (sec)
[…]
Mar 31 20:28:47 archlinux php[10631]: [18:28:47/25144] Base feed: http://feeds.feedburner.com/hackaday/LgoM
Mar 31 20:28:47 archlinux php[10631]: [18:28:47/25144]  => 2016-03-31 17:56:45, 107 2
Mar 31 20:28:48 archlinux php[10631]: [18:28:48/25144]     0.7838 (sec)
Mar 31 20:28:48 archlinux php[10631]: [18:28:48/25144]  => 2016-03-31 17:56:46, 283 5
Mar 31 20:28:49 archlinux php[10631]: [18:28:49/25144]     0.7581 (sec)
[…]
Mar 31 20:29:02 archlinux php[10631]: [18:29:02/25144] Base feed: https://netzpolitik.org/feed/
Mar 31 20:29:02 archlinux php[10631]: [18:29:02/25144]  => 2016-03-31 17:57:08, 602 2
Mar 31 20:29:03 archlinux php[10631]: [18:29:03/25144]     1.3108 (sec)
Mar 31 20:29:03 archlinux php[10631]: [18:29:03/25144]  => 2016-03-31 17:57:10, 1040 6
Mar 31 20:29:04 archlinux php[10631]: [18:29:04/25144]     0.9161 (sec)
[…]

If I recall correctly there are multiple update methods and I am running the update2_daemon.php script in a systemd unit, so apparently I am using that one. It's been a few years since I set this up…

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 31 Mar 2016, 22:16

well that's not supposed to happen i think

mysql or postgres? also: versions of everything including tt-rss

ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Re: Feeds with updates disabled still updating

Postby ajs124 » 01 Apr 2016, 01:23

mysql, or rather mariadb 10.1.13, php 7.0.5, tt-rss is master, so c71add385dc87d489df3a6e9db9353f92233ec84, while the logs I posted earlier were created by 465fb16d3312b302fdf8fe0ceb8dfa51b6ad239b.
My install has this diff to origin/master

Code: Select all

diff --git a/css/tt-rss.css b/css/tt-rss.css
index 589f96b..95d9f87 100644
--- a/css/tt-rss.css
+++ b/css/tt-rss.css
@@ -630,10 +630,6 @@ div#headlines-frame.wide .hlTitle {
        white-space : normal;
 }
 
-div#headlines-frame.wide .hl .hlFeed {
-       display : none;
-}
-
 .hl a.title.high, span.hlContent.high .contentPreview {
        color : #00aa00;
 }
diff --git a/include/functions.php b/include/functions.php
index d6bd5fb..5712cb9 100755
--- a/include/functions.php
+++ b/include/functions.php
@@ -386,7 +386,7 @@
 
                        curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, $timeout ? $timeout : FILE_FETCH_CONNECT_TIMEOUT);
                        curl_setopt($ch, CURLOPT_TIMEOUT, $timeout ? $timeout : FILE_FETCH_TIMEOUT);
-                       curl_setopt($ch, CURLOPT_FOLLOWLOCATION, !ini_get("open_basedir"));
+                       curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
                        curl_setopt($ch, CURLOPT_MAXREDIRS, 20);
                        curl_setopt($ch, CURLOPT_BINARYTRANSFER, true);
                        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);

I think I actually reported that curl thing sometime back and it was related to redirects and works for in my setup…

I'm unsure if any other software versions (like nginx 1.8.1 or linux kernel 4.1.x) are relevant, but as you can tell from the logs, the server runs arch linux and is up to date.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 01 Apr 2016, 07:37

btw you sure you're not double clicking any of the disabled feeds? that might either queue (i.e. set last_updated to 1970-01-01) or directly update one in background

ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Re: Feeds with updates disabled still updating

Postby ajs124 » 01 Apr 2016, 12:42

I was not aware of the fact that double clicking would cause an update, but I'm >90% certain, that that's not the problem. There were, for example, new entries from those feeds in my reader this morning which were added between me last opening tt-rss and that morning and I did not double click the feed this morning.

Since the client side can apparently trigger an update: I'm also using the official android app. And for the webinterface my client is the most recent stable firefox release (45.0.1).

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 01 Apr 2016, 13:01

well the feeds with the update_interval set to -1 are specifically excluded from any automated update processes (unless last_updated is "never") so i'm not sure what could be causing this tbh

you can try temporarily commenting out the block starting with if ($any_needs_curl) in classes/feeds.php:188 but it probably won't help

e: you can also email me your database dump i guess

ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Re: Feeds with updates disabled still updating

Postby ajs124 » 01 Apr 2016, 18:04

Commenting out that code in feeds.php does not seem to have helped.

About the feeds being excluded: how are feeds and their updates separated between different users? I suspect this problem arises somehow because there are multiple users with the exact same feed…

I will send you a database dump after I got the permission/consent from the other users on my server.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 01 Apr 2016, 18:40

>I suspect this problem arises somehow because there are multiple users with the exact same feed…

no shit

you can see the relevant queries for yourself in rssfuncs.php

e: nevermind the database, looks like i replicated this here

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 01 Apr 2016, 18:56

this should be fixed in current git (unless i broke everything)

ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Re: Feeds with updates disabled still updating

Postby ajs124 » 02 Apr 2016, 13:19

Yup, seems to work now. Thanks for writing and maintaining tt-rss.


Return to “Development”

Who is online

Users browsing this forum: Google [Bot] and 2 guests