Problem with "disable updates" feeds again

Questions about http://online.tt-rss.org go here
conzeit
Bear Rating Trainee
Bear Rating Trainee
Posts: 6
Joined: 22 Oct 2011, 23:07

Problem with "disable updates" feeds again

Postby conzeit » 01 Jun 2012, 20:15

since about a week some feed folders set to "disable updates" keep updating often, for no reason that I can see. I guess I could just remove these feeds, but I like to view them sporadically and not get updates the rest of the time.

Please help me oh wonderous fox. :p Sorry to bother so much (seems I'm the only one who posts here and it's often these little bugs)

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Problem with "disable updates" feeds again

Postby fox » 01 Jun 2012, 21:50

Weird, this probably is related to latest changes with manual update handling. I'll look into it.

User avatar
gmargo
Bear Rating Disaster
Bear Rating Disaster
Posts: 62
Joined: 08 Jan 2012, 22:33
Location: Silicon Valley

Re: Problem with "disable updates" feeds again

Postby gmargo » 02 Jun 2012, 05:48

What version of the code are you using? The lastest in git, or a specific release?

I haven't seen a problem so far, but now I've got several feeds with updates disabled, so I'll look out for problems.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Problem with "disable updates" feeds again

Postby fox » 02 Jun 2012, 08:40

Online is currently at last release I think.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Problem with "disable updates" feeds again

Postby fox » 02 Jun 2012, 11:20

Disabled feeds definitely do update now, so looks like you broke it. :)

Code: Select all

  $update_limit_qpart = "AND ((
               ttrss_feeds.update_interval = 0
               AND ttrss_feeds.last_updated < NOW() - CAST((ttrss_user_prefs.value || ' minutes') AS INTERVAL)
            ) OR (
               ttrss_feeds.update_interval > 0
               AND ttrss_feeds.last_updated < NOW() - CAST((ttrss_feeds.update_interval || ' minutes') AS INTERVAL)
            ) OR ttrss_feeds.last_updated IS NULL
            OR last_updated = '1970-01-01 00:00:00')";


Last clause is going to match feeds with update_interval < 0 if they have never been updated or manual update have been scheduled (which makes sense, we want feeds to be updated manually even when auto-updates are disabled). Maybe that's what happens? If so, I don't see this as broken.

btw just wanted to mention that I'm not using feedburner anymore for forum rss feed (forum/rss.php).

Edit: Yep, only feeds that updated for me had 1970-01-01 last_updated, so I tend to file this as "works as intended".

User avatar
gmargo
Bear Rating Disaster
Bear Rating Disaster
Posts: 62
Joined: 08 Jan 2012, 22:33
Location: Silicon Valley

Re: Problem with "disable updates" feeds again

Postby gmargo » 03 Jun 2012, 05:51

fox wrote:Online is currently at last release I think.


Sorry I didn't make it clear - I was asking for the OP's version. Moot now.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Problem with "disable updates" feeds again

Postby fox » 03 Jun 2012, 11:03

Yep, I've posted the version cause this was asked in Online forum. :)


Return to “Online”

Who is online

Users browsing this forum: No registered users and 0 guests